Offer a final review in Finalize

AI Assisted
This commit is contained in:
jparkerweb committed 2026-11-03 10:13:51 -08:00
1 parent 8e1af1b15d
commit d6be7f9240
12 files changed
+62 -22

No files matched your search

+1 -1
View File
@@ -31,7 +31,7 @@ export const BUDGETS = {
"changelog.md": 1400,
"diagnose.md": 2700,
"document.md": 400,
"finalize.md": 1600,
"finalize.md": 2000,
"git.md": 6500,
"handoff.md": 300,
"implement.md": 5700,
+7 -6
View File
@@ -272,11 +272,12 @@ test("every dashboard card is filled in and launches a real skill", () => {
// The review button runs review.md inside the build's own session, so the
// skills that offer it have to carry review.md and its references.
test("the skills that run a review on the page carry the review", () => {
for (const skill of ["plan2code-3-implement", "plan2code-quick-task", "plan2code-3-implement-review"]) {
for (const skill of ["plan2code-3-implement", "plan2code-quick-task", "plan2code-3-implement-review", "plan2code-4-finalize"]) {
const refs = path.join(ROOT, "skills", skill, "references");
for (const f of ["review.md", "dimensions.md", "false-positives.md", "session-end.md", "verification-protocol.md"]) {
for (const f of ["review.md", "dimensions.md", "false-positives.md", "session-end.md", "verification-protocol.md", "reviewer-brief.md", "helper-strength.md"]) {
assert.ok(fs.existsSync(path.join(refs, f)), `${skill} must carry references/${f}`);
}
assert.ok(fs.existsSync(path.join(ROOT, "skills", skill, "scripts", "review-scope.mjs")), `${skill} must carry scripts/review-scope.mjs`);
}
});
@@ -2018,16 +2019,16 @@ test("workspace cursor never moves backwards, and only changes past it are pendi
}
});
test("subagents: only the twelve opted-in workflows offer the switch", () => {
for (const w of ["init", "init-update", "pathfinder", "plan", "revise-plan", "document", "implement", "implement-review", "quick-task", "review", "xray", "diagnose"]) {
test("subagents: only the thirteen opted-in workflows offer the switch", () => {
for (const w of ["init", "init-update", "pathfinder", "plan", "revise-plan", "document", "implement", "implement-review", "quick-task", "review", "finalize", "xray", "diagnose"]) {
assert.equal(offered(w), true, w);
assert.ok(defaultInstruction(w).length > 0, `${w} has a default instruction`);
}
for (const w of ["dashboard", "finalize", "changelog", "git", "handoff", "constructor", "toString", undefined]) {
for (const w of ["dashboard", "changelog", "git", "handoff", "constructor", "toString", undefined]) {
assert.equal(offered(w), false, String(w));
assert.equal(defaultInstruction(w), "");
}
assert.equal(Object.keys(SUBAGENT_WORKFLOWS).length, 12);
assert.equal(Object.keys(SUBAGENT_WORKFLOWS).length, 13);
assert.deepEqual(defaultSetting("review"), { workflow: "review", on: true, instruction: null, max: 3, strength: "balanced" });
assert.equal(defaultSetting("changelog").on, false, "a skill without the switch is never on");
assert.equal(effectiveInstruction({ workflow: "review", instruction: " " }), defaultInstruction("review"));
+2 -1
View File
@@ -399,7 +399,7 @@ test("Implement's card launches Implement + Review when Review is ticked", () =>
assert.equal(launchVariant(quick, true), quick, "a card with no Review box is unchanged");
});
test("helper-strength.md ships in the twelve skills that start helpers, and in no other", () => {
test("helper-strength.md ships in the thirteen skills that start helpers, and in no other", () => {
// npm test has just built skills/; a direct run builds it so the check never reads a stale tree.
if (process.env.npm_lifecycle_event !== "test") {
execFileSync(process.execPath, [path.join(ROOT, "install.js"), "--build-skills"], { stdio: "ignore" });
@@ -413,6 +413,7 @@ test("helper-strength.md ships in the twelve skills that start helpers, and in n
"plan2code-2-document",
"plan2code-3-implement",
"plan2code-3-implement-review",
"plan2code-4-finalize",
"plan2code-diagnose",
"plan2code-init",
"plan2code-init-update",