From d4b604ba7f79c3d722fbdf98e7dacb04d4962043 Mon Sep 17 00:00:00 2001 From: Justin Parker Date: Sun, 8 Nov 2026 23:14:26 -0800 Subject: [PATCH] Clear a pressed Review when a different finish replaces it AI Assisted --- scripts/test-web-console-page-session.mjs | 17 +++++++++++++++++ scripts/test-web-console-state.mjs | 1 + src/web-console/public/screens/core.js | 11 ++++++++++- src/web-console/public/screens/ending.js | 2 ++ src/web-console/public/selectors.js | 5 +++++ src/web-console/public/state.js | 2 ++ 6 files changed, 37 insertions(+), 1 deletion(-) diff --git a/scripts/test-web-console-page-session.mjs b/scripts/test-web-console-page-session.mjs index 9339972..6c5d3f6 100644 --- a/scripts/test-web-console-page-session.mjs +++ b/scripts/test-web-console-page-session.mjs @@ -1042,6 +1042,23 @@ test("Before you close this shows while a review is on offer, goes while it is a assert.equal(await closeGuide(s).count(), 0, "the guide came back on a reload"); }); +// What a person sees break: Commit, Changelog and Dashboard dead on the finish after a review, because the agent posted the new finish without clearing the old one. +test("a different finish posted over a pressed Review starts with its own buttons live", async (t) => { + const s = await openSession(await suite.browser(), { t, workflow: "quick-task", payload: { agent: { status: "working", activity: "Task 1 of 1" } } }); + s.post({ finish: OFFERS }); + const main = s.page.locator("#main"); + await main.getByRole("button", { name: "Review it now" }).click(); + await main.getByRole("button", { name: "Review requested…" }).waitFor(); + collect(s); + s.post({ finish: { ...OFFERS, headline: "The review is done", review: false } }); + await main.getByRole("heading", { name: "The review is done" }).waitFor(); + await s.page.waitForFunction(() => { + const b = [...document.querySelectorAll("#main button")].find((x) => x.textContent.trim() === "Commit it now"); + return b && !b.disabled; + }); + assert.equal(await main.getByRole("button", { name: "Commit it now" }).isEnabled(), true, "Commit stayed dead after the new finish"); +}); + // What a person sees break: the guide missing while a commit or the dashboard // is starting (it would say "start a new one" under "Opening Git"), or missing // once they said they are done or the server is gone. diff --git a/scripts/test-web-console-state.mjs b/scripts/test-web-console-state.mjs index f4aa3b5..97bb280 100644 --- a/scripts/test-web-console-state.mjs +++ b/scripts/test-web-console-state.mjs @@ -19,6 +19,7 @@ test("state: page starts as app.js always started it", () => { sent: {}, stopping: null, afterBuild: null, + afterBuildFinish: null, homeward: null, launching: null, deleting: null, diff --git a/src/web-console/public/screens/core.js b/src/web-console/public/screens/core.js index 6837b68..180b3a1 100644 --- a/src/web-console/public/screens/core.js +++ b/src/web-console/public/screens/core.js @@ -55,7 +55,7 @@ import { FOOTER_TIERS, footerLabel } from "../workspace.js"; import { activity, agentAdrift, agentWorking, askBusy, loopDriving, loopWaiting, loopWaitingKey, asked, awaitingReply, byId, dashboardLive, docs, doingNow, AGENTS_VIEW, agentsTabShown, finish, gitAwaiting, isDashboard, isGitBoard, isOpen, isSpecFileView, items, loadAgentsDoc, loadOverview, myTurn, openItems, - patience, pressStranded, reviewPending, scan, selSpec, sendCollected, specFileTabs, stagedCount, stranded, + finishKey, patience, pressStranded, reviewPending, scan, selSpec, sendCollected, specFileTabs, stagedCount, stranded, topics, workingMs, WORKING_GRACE_MS, workspaceFolders, } from "../selectors.js"; @@ -394,6 +394,15 @@ export function adopt(body) { // with its own offer unanswered. if (!finish() && page.local.afterBuild) { page.local.afterBuild = null; + page.local.afterBuildFinish = null; + save(); + } + // Same when the agent took the review up and posted a different finish + // without clearing the old one: the press was on the old finish, so the new + // finish's Commit, Changelog and Dashboard start live. + if (page.local.afterBuild === "review" && finish() && page.local.afterBuildFinish && page.local.afterBuildFinish !== finishKey(finish())) { + page.local.afterBuild = null; + page.local.afterBuildFinish = null; save(); } // A way home that ended in a finish instead (the agent paused rather than diff --git a/src/web-console/public/screens/ending.js b/src/web-console/public/screens/ending.js index d0dd788..d92b5ad 100644 --- a/src/web-console/public/screens/ending.js +++ b/src/web-console/public/screens/ending.js @@ -38,6 +38,7 @@ import { reviewPending, docs, finish, + finishKey, agentAdrift, agentWorking, awaitingReply, @@ -645,6 +646,7 @@ async function sendAfterBuild(kind, launch = null) { } if (!res.ok) throw new Error(String(res.status)); page.local.afterBuild = kind; + page.local.afterBuildFinish = finishKey(finish()); page.pendingResult = true; saveNow(); const started = { diff --git a/src/web-console/public/selectors.js b/src/web-console/public/selectors.js index 273d17e..1aff109 100644 --- a/src/web-console/public/selectors.js +++ b/src/web-console/public/selectors.js @@ -71,6 +71,11 @@ export const stagedCount = () => Object.keys(page.local.staged).length; // sessions end with nothing left to run. export const finish = () => (page.S && page.S.finish && typeof page.S.finish === "object" ? page.S.finish : null); +// A finish's identity: what a press was made against. A different finish +// replacing it (the agent took the review up and posted a new one without +// clearing the old) is a new offer, not the old press's answer. +export const finishKey = (fin) => (fin ? JSON.stringify([fin.headline, fin.command, fin.body]) : null); + // The dashboard is the one workflow that is not a conversation: a menu of the // skills, rendered from the page's own catalog, where a click IS the answer. export const isDashboard = () => page.S && page.S.workflow === "dashboard"; diff --git a/src/web-console/public/state.js b/src/web-console/public/state.js index eae47ac..164baa6 100644 --- a/src/web-console/public/state.js +++ b/src/web-console/public/state.js @@ -42,6 +42,8 @@ export function fresh() { sent: {}, stopping: null, afterBuild: null, + // The finish `afterBuild` was pressed on (finishKey), so a different one is a new offer. + afterBuildFinish: null, homeward: null, launching: null, // A picker Delete sent and not yet answered by a rescan: { dir, scanAt }.