mirror of
https://github.com/jparkerweb/plan2code.git
synced 2026-11-17 20:51:19 -08:00
Ask once before Finalize's rating questions, with a No thank you
AI Assisted
This commit is contained in:
1 parent
7f95dabd00
commit
8491764273
3 files changed
+26
-3
No files matched your search
@@ -1,4 +1,5 @@
|
|||||||
// Tests for plan2code-4-finalize's scripts/feedback-payload.mjs.
|
// Tests for plan2code-4-finalize's scripts/feedback-payload.mjs and Step 5's
|
||||||
|
// opening question.
|
||||||
//
|
//
|
||||||
// See skill-script-helpers.mjs for how these run.
|
// See skill-script-helpers.mjs for how these run.
|
||||||
|
|
||||||
@@ -172,3 +173,25 @@ test("feedback-payload: submit refuses an oversize URL when gh fails, and dry-ru
|
|||||||
assert.match(j.next, /--truncate/);
|
assert.match(j.next, /--truncate/);
|
||||||
assert.match(j.next, /gh/);
|
assert.match(j.next, /gh/);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
/* ===================================================== Step 5's opening question */
|
||||||
|
|
||||||
|
// What a person sees break: Finalize posts the rating and reason cards straight
|
||||||
|
// away, and opting out takes a scroll to Skip on every one of them.
|
||||||
|
test("Step 5 asks one question first, with a No thank you, on the page and in the terminal", () => {
|
||||||
|
const notes = fs.readFileSync(path.join(ROOT, "src/web-console/notes/finalize.md"), "utf8");
|
||||||
|
const row = notes.split("\n").find((line) => line.startsWith("| 5, Feedback"));
|
||||||
|
assert.ok(row, "the notes have a row for Step 5");
|
||||||
|
const opening = row.indexOf('`confirm` "Rate this run"');
|
||||||
|
assert.ok(opening !== -1, "the row opens on the Rate this run card");
|
||||||
|
assert.match(row, /`noLabel` "No thank you"/);
|
||||||
|
assert.ok(opening < row.indexOf("rating as `choice`"), "the opening card comes before the rating card");
|
||||||
|
assert.ok(row.indexOf("No thank you") < row.indexOf("rating as `choice`"), "the way out comes before the rating card");
|
||||||
|
assert.match(row, /No: Step 6, no more cards/, "No thank you ends the questions on the page");
|
||||||
|
|
||||||
|
const prompt = fs.readFileSync(path.join(ROOT, "src/plan2code-4-finalize.md"), "utf8");
|
||||||
|
const step = prompt.slice(prompt.indexOf("### STEP 5:"), prompt.indexOf("### STEP 6:"));
|
||||||
|
assert.match(step, /on its own/, "the prompt asks the opening question alone");
|
||||||
|
assert.ok(step.indexOf("on its own") < step.indexOf("**Rating**"), "the opening question comes before the rating");
|
||||||
|
assert.match(step, /On no, skip to Step 6 and ask nothing more/, "no ends the questions in the terminal");
|
||||||
|
});
|
||||||
@@ -240,7 +240,7 @@ Do NOT make documentation changes without user approval.
|
|||||||
|
|
||||||
**Objective:** Collect optional feedback before archival.
|
**Objective:** Collect optional feedback before archival.
|
||||||
|
|
||||||
Ask the user: "Would you like to provide feedback on this run? (optional)" If no, skip to Step 6.
|
Ask this one question on its own, before any of the others: "Would you like to rate this run? (yes / no thank you)" On no, skip to Step 6 and ask nothing more about feedback.
|
||||||
|
|
||||||
If yes, collect:
|
If yes, collect:
|
||||||
1. **Rating** (1-10): "How would you rate this workflow run overall?"
|
1. **Rating** (1-10): "How would you rate this workflow run overall?"
|
||||||
|
|||||||
@@ -7,7 +7,7 @@
|
|||||||
| 2.5, Final review | Always: `confirm` "Run a final review" (`yesLabel` "Review it", `noLabel` "Skip it", files and ~lines in `body`). Yes: `building-review.md`, the `finalize` door. |
|
| 2.5, Final review | Always: `confirm` "Run a final review" (`yesLabel` "Review it", `noLabel` "Skip it", files and ~lines in `body`). Yes: `building-review.md`, the `finalize` door. |
|
||||||
| 3, Summary | Written to `overview.md`; mirror it as a doc (`saved`, `file` block). |
|
| 3, Summary | Written to `overview.md`; mirror it as a doc (`saved`, `file` block). |
|
||||||
| 4, Docs review | Proposed-updates table as a doc, plus a `multi` of documents (ticked = approved, `required:false` so Skip means no doc changes); a `review` if all-or-nothing. |
|
| 4, Docs review | Proposed-updates table as a doc, plus a `multi` of documents (ticked = approved, `required:false` so Skip means no doc changes); a `review` if all-or-nothing. |
|
||||||
| 5, Feedback | `required:false`: rating as `choice` 1 to 10 or `text`, three reasons as `text`, maintainer consent as `confirm`. |
|
| 5, Feedback | Alone first: `confirm` "Rate this run" (`yesLabel` "Rate it", `noLabel` "No thank you"). No: Step 6, no more cards. Yes, `required:false`: rating as `choice` 1 to 10 or `text`, three reasons as `text`, maintainer consent as `confirm`. |
|
||||||
| 6, Cleanup | `review` (`doc` Step 3's summary), verdicts `yes` ("Archive it"), `show` (token `show me`), `no`; archive paths in `body`, and a line that remembered workspace folders are forgotten too (`console.mjs forget --spec specs/<feature>` after the move). On `show`, see `notes/implement.md`, then reopen without `show`. |
|
| 6, Cleanup | `review` (`doc` Step 3's summary), verdicts `yes` ("Archive it"), `show` (token `show me`), `no`; archive paths in `body`, and a line that remembered workspace folders are forgotten too (`console.mjs forget --spec specs/<feature>` after the move). On `show`, see `notes/implement.md`, then reopen without `show`. |
|
||||||
|
|
||||||
Post `activity` as each step starts. Pass `--spec specs/<feature>` or post `specDir`.
|
Post `activity` as each step starts. Pass `--spec specs/<feature>` or post `specDir`.
|
||||||
|
|||||||
Reference in new issue
Block a user