Offer a final review of the removals at the end of the Dead Code skill, run in the same session

AI Assisted
This commit is contained in:
jparkerweb committed 2026-11-10 12:46:18 -08:00
1 parent b3768b47a3
commit 7f32c351b1
12 files changed
+65 -17

No files matched your search

+1 -1
View File
@@ -29,7 +29,7 @@ export const BUDGETS = {
// Each topic file under notes/, read when its workflow starts.
notes: {
"changelog.md": 1400,
"dead-code.md": 4250,
"dead-code.md": 4900,
"diagnose.md": 2700,
"document.md": 400,
"finalize.md": 2000,
+16
View File
@@ -1225,3 +1225,19 @@ test("run: each tail line is capped at 400 characters", () => {
assert.equal(r.json.tail.length, 1);
assert.equal(r.json.tail[0].length, 400);
});
/* ---------------------------------------------------- the final review */
test("the built skill ships the Review files its Step 7.5 final review reads", () => {
const refs = path.join(SKILLS, "plan2code-dead-code", "references");
for (const file of ["review.md", "review-in-build.md", "test-runs.md", "reviewer-brief.md", "verification-protocol.md", "dimensions.md", "false-positives.md", "session-end.md"]) {
assert.ok(fs.existsSync(path.join(refs, file)), `references/${file} is missing from plan2code-dead-code`);
}
// review.md runs these from <S>.
for (const script of ["specs.mjs", "commit-msg.mjs", "review-scope.mjs"]) {
assert.ok(fs.existsSync(path.join(SKILLS, "plan2code-dead-code", "scripts", script)), `scripts/${script} is missing from plan2code-dead-code`);
}
const skill = fs.readFileSync(path.join(SKILLS, "plan2code-dead-code", "SKILL.md"), "utf8");
assert.match(skill, /### Step 7\.5: Final review/);
for (const ref of ["references/review.md", "references/review-in-build.md"]) assert.ok(skill.includes(ref), `SKILL.md names ${ref}`);
});
+2 -1
View File
@@ -47,7 +47,7 @@ test("Document writes Targeted, Quick checks and Full suite lines and reads test
assert.match(doc, /no Full Suite row: ask/);
});
test("test-runs.md ships in the eight skills that run, write or offer tests, and in no other", () => {
test("test-runs.md ships in the nine skills that run, write or offer tests, and in no other", () => {
// npm test has just built skills/; a direct run builds it so the check never reads a stale tree.
if (process.env.npm_lifecycle_event !== "test") {
execFileSync(process.execPath, [path.join(ROOT, "install.js"), "--build-skills"], { stdio: "ignore" });
@@ -59,6 +59,7 @@ test("test-runs.md ships in the eight skills that run, write or offer tests, and
"plan2code-3-implement",
"plan2code-3-implement-review",
"plan2code-4-finalize",
"plan2code-dead-code",
"plan2code-pr-prep",
"plan2code-quick-task",
"plan2code-review",