From 037fb0d864c9777d6217ea5ba9f8423f458149eb Mon Sep 17 00:00:00 2001 From: Justin Parker Date: Fri, 6 Nov 2026 17:17:36 -0800 Subject: [PATCH] Turn activity music on by default, like the activity sounds AI Assisted --- .readme/web-console.md | 4 ++-- scripts/test-web-console-page-activities.mjs | 8 ++++---- src/web-console/public/looks.js | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.readme/web-console.md b/.readme/web-console.md index 24bac70..6dcfbf2 100644 --- a/.readme/web-console.md +++ b/.readme/web-console.md @@ -550,8 +550,8 @@ Drive has a song for each road, Snake a different one at every level, dealt from the start of a round so none repeats, and Ghoul Rush a track for each room, played at one steady level and fuller in a boss fight), and Light Trails and Flock Dash play five recorded songs each as background music, each in full, one after another in an -order shuffled for every run: turn on **Play activity music** in **User -Preferences → Sounds & activities** (it starts off). **Play activity sounds** there turns the games' +order shuffled for every run: **Play activity music** in **User +Preferences → Sounds & activities** is on by default (turn it off there). **Play activity sounds** there turns the games' sounds (the 3, 2, 1 and the new-best burst included) and their music on or off and leaves the page's own cues alone; the **Play sounds** switch above it silences all of it, and a paused or closed game goes quiet at once. A game diff --git a/scripts/test-web-console-page-activities.mjs b/scripts/test-web-console-page-activities.mjs index 05e7bf0..a044a13 100644 --- a/scripts/test-web-console-page-activities.mjs +++ b/scripts/test-web-console-page-activities.mjs @@ -1259,12 +1259,12 @@ test("Play activity sounds in User Preferences silences the games and the countd await s.page.click("#btn-looks"); await s.page.click("#prefs-tab-sounds"); const tune = s.page.locator("#looks-game-music"); - assert.equal(await tune.isChecked(), false, "game music is off by default"); - await tune.check(); - await s.page.waitForFunction(async () => ((await (await fetch("/looks")).json()).looks || {}).gameMusic === true); + assert.equal(await tune.isChecked(), true, "game music is on by default"); + await tune.uncheck(); + await s.page.waitForFunction(async () => ((await (await fetch("/looks")).json()).looks || {}).gameMusic === false); await s.page.click("#looks-reset"); await s.page.locator("#looks-activity-sounds:checked").waitFor(); - await s.page.waitForFunction(async () => ((await (await fetch("/looks")).json()).looks || {}).gameMusic === false); + await s.page.waitForFunction(async () => ((await (await fetch("/looks")).json()).looks || {}).gameMusic === true); await s.page.waitForFunction(async () => ((await (await fetch("/looks")).json()).looks || {}).activitySounds === true); }); diff --git a/src/web-console/public/looks.js b/src/web-console/public/looks.js index 933bb88..fa5ba29 100644 --- a/src/web-console/public/looks.js +++ b/src/web-console/public/looks.js @@ -37,8 +37,8 @@ export const DEFAULT_LOOKS = { // course (activityBestGolfPirate), each a flat key for cleanLooks(). hideActivities: true, activitySounds: true, - // Whether a game plays its music too (chiptune or recorded songs): off until asked for. - gameMusic: false, + // Whether a game plays its music too (chiptune or recorded songs): on, like the sounds. + gameMusic: true, lastActivity: "", ...Object.fromEntries(ACTIVITIES.flatMap((a) => bestKeys(a).map((key) => [key, 0]))), // And one memo per game (activityMemoSnake): Snake's surprises found.